Skip to content

Feat/color grading - #334

Open
Deezper wants to merge 4 commits into
Hardhat-Enterprises:devfrom
Deezper:feat/color-grading
Open

Feat/color grading#334
Deezper wants to merge 4 commits into
Hardhat-Enterprises:devfrom
Deezper:feat/color-grading

Conversation

@Deezper

@Deezper Deezper commented Sep 11, 2025

Copy link
Copy Markdown

Replace score with count-based bands

Thresholds: LOW 0–14, MEDIUM 15–59, HIGH 60+

Theme updates via ThreatThemeManager (cards recolor automatically)

Updated: DatabaseThreatRepository, ThreatRepository, MainViewModel, MainActivity, drawables

Boundary checks: 14→15 and 59→60

@Lillian-ran Lillian-ran left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Deezper, I noticed there are unresolved merge conflict markers (<<<<<<<, =======, >>>>>>>) left in this file (MainActivity.java).
Please resolve the conflicts locally before pushing again: Edit the file to manually keep the correct code and remove the conflict markers, then commit and push the cleaned file.

@Deezper

Deezper commented Sep 17, 2025

Copy link
Copy Markdown
Author

Hi Yanran,

Ive done the changes now

@Lillian-ran

Copy link
Copy Markdown
Collaborator

Hi Deezper, thanks for updating the PR.

I tested the changes but currently I’m unable to log into the app — after entering account and password, it just loops back to the login page. This seems to be related to the changes in MainActivity.java. Could you please review and fix this issue?

Also, for clarity and easier testing, I suggest adding a short demo video of your feature working. That will help us quickly verify the functionality.

Thanks!

@Lillian-ran Lillian-ran added the bug Something isn't working label Sep 18, 2025
@Deezper

Deezper commented Sep 18, 2025

Copy link
Copy Markdown
Author

Hi Yanran,

Thanks for the feedback i have revieved and done the necessary changes and below attached is the demo video

https://drive.google.com/file/d/1QbuNMGBMAEXfIIHmg4jhMrCRrBnbKpCV/view?usp=sharing

@Deezper

Deezper commented Sep 26, 2025

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants